SREP-4796: Allow CreateMustGather alert in conformance tests

[dustman9000]

Summary

Add CreateMustGather to the AllowedAlertNames list so it does not fail the "shouldn't report any alerts in firing state" conformance test.

Why

CreateMustGather is a managed-cluster-config meta-alert that fires when any other alert has been active for 15 minutes. It triggers CAD (configuration-anomaly-detection) to collect a must-gather for debugging. On CI clusters, transient alerts during cluster install settling trigger CreateMustGather, which persists after the underlying alert resolves and fails conformance testing.

This has caused the alert to be reverted from MCC twice.

Context

• Jira: SREP-4796
• CAD repo: https://github.com/openshift/configuration-anomaly-detection
• MCC revert PR: Revert SREP-4581: CreateMustGather alert causing conformance failures managed-cluster-config#2729
• Original initiative: SREP-4025

Test plan

• CI conformance jobs should no longer fail when CreateMustGather fires during cluster settling
• The alert can then be re-added to MCC with an additional install-settling guard

Summary by CodeRabbit

• New Features
  • Added support for an additional alert type: CreateMustGather, expanding recognized monitoring alerts.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@dustman9000: This pull request references SREP-4796 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add CreateMustGather to the AllowedAlertNames list so it does not fail the "shouldn't report any alerts in firing state" conformance test.

Why

CreateMustGather is a managed-cluster-config meta-alert that fires when any other alert has been active for 15 minutes. It triggers CAD (configuration-anomaly-detection) to collect a must-gather for debugging. On CI clusters, transient alerts during cluster install settling trigger CreateMustGather, which persists after the underlying alert resolves and fails conformance testing.

This has caused the alert to be reverted from MCC twice.

Context

• Jira: SREP-4796
• CAD repo: https://github.com/openshift/configuration-anomaly-detection
• MCC revert PR: Revert SREP-4581: CreateMustGather alert causing conformance failures managed-cluster-config#2729
• Original initiative: SREP-4025

Test plan

• CI conformance jobs should no longer fail when CreateMustGather fires during cluster settling
• The alert can then be re-added to MCC with an additional install-settling guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6f0913a1-5f81-4b4b-97e4-c3d4114dd26a

📥 Commits

Reviewing files that changed from the base of the PR and between 03d8262 and 88d7dc6.

📒 Files selected for processing (1)

• pkg/monitortestlibrary/allowedalerts/types.go

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/monitortestlibrary/allowedalerts/types.go

---

Walkthrough

The PR adds the alert name CreateMustGather to the exported AllowedAlertNames slice in pkg/monitortestlibrary/allowedalerts/types.go (with an inline issue reference). No other logic was changed.

Changes

Allowed Alert Update

Layer / File(s)	Summary
Data Shape pkg/monitortestlibrary/allowedalerts/types.go	AllowedAlertNames slice gains a new entry: "CreateMustGather" (comment: https://issues.redhat.com/browse/SREP-4796).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding the CreateMustGather alert to the allowed list for conformance tests, which matches the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies AllowedAlertNames constant, not test code. No new Ginkgo tests added. Existing test using this constant has stable, deterministic title.
Test Structure And Quality	✅ Passed	The custom check targets Ginkgo test code quality, but the test file added in this PR uses testify/assert with testing.T, not Ginkgo BDD patterns. The check is not applicable.
Microshift Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests. It only adds "CreateMustGather" to an alert exclusion list. MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests. Only modifies AllowedAlertNames config constant in test library. SNO check only applies when new tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR only modifies a test library's alert allowlist, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced, so this check does not apply.
Ote Binary Stdout Contract	✅ Passed	PR adds a single string literal to AllowedAlertNames array. No process-level code, logging calls, or stdout writes present. Change is pure data structure update with no side effects.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only updates the AllowedAlertNames list by adding "CreateMustGather" alert. The check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dustman9000
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	88d7dc6	link	true	/test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.