Skip to content

DPTP-3787: Add referenceRelease to ci imagestreams for OCP 4.23 and 5.0#80063

Open
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:reference-release-ci-imagestreams-4.23-5.0
Open

DPTP-3787: Add referenceRelease to ci imagestreams for OCP 4.23 and 5.0#80063
deepsm007 wants to merge 1 commit into
openshift:mainfrom
deepsm007:reference-release-ci-imagestreams-4.23-5.0

Conversation

@deepsm007

@deepsm007 deepsm007 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

openshift/ci-tools#5233

/cc @openshift/test-platform @bradmwilliams
/hold

Summary by CodeRabbit

This PR updates the OpenShift release controller configuration for OCP 4.23 and 5.0 CI builds to add reference release mirror configurations.

Changes made:

  • Modified core-services/release-controller/_releases/release-ocp-4.23-ci.json and release-ocp-5.0-ci.json to add referenceRelease configuration for the 4.23.0-0.ci and 5.0.0-0.ci releases respectively
  • Each updated file now specifies:
    • Push repository: quay.io/openshift/ci
    • Pull repository: quay-proxy.ci.openshift.org/openshift/ci
    • Mirror secret: release-controller-quay-mirror-secret
    • Reference mode: "source"

Impact:
These changes configure CI image mirroring for the release controller, enabling OCP 4.23 and 5.0 CI builds to use Quay mirror repositories for storing and retrieving container images during the release process. This complements the ci-tools changes referenced in the related PR.

@openshift-ci openshift-ci Bot requested review from a team and bradmwilliams June 3, 2026 21:57
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Release configurations for OpenShift 4.23 and 5.0 are updated with new referenceRelease and referenceMode fields. These additions specify mirror repository endpoints, authentication secrets for pulling and pushing container images, and set the reference mode to "source".

Changes

Release reference configuration

Layer / File(s) Summary
Release mirror and reference mode configuration
core-services/release-controller/_releases/release-ocp-4.23-ci.json, core-services/release-controller/_releases/release-ocp-5.0-ci.json
Both release definitions add referenceRelease objects specifying pushRepository, pullRepository, and secretName for release artifact mirroring, and set referenceMode to "source".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only JSON configuration files for OCP release definitions; no Ginkgo tests or test files are present, making the test naming check not applicable.
Test Structure And Quality ✅ Passed PR contains only JSON configuration file changes (release-ocp-4.23-ci.json and release-ocp-5.0-ci.json), with no Ginkgo test code present. Custom check for test structure/quality is not applicable.
Microshift Test Compatibility ✅ Passed PR contains only JSON configuration changes for release definitions, not Ginkgo e2e tests. MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies release controller configuration JSON files, adding referenceRelease fields. No new Ginkgo e2e tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies release definition configuration files only, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only JSON release controller configuration files, not test binaries or code. The OTE Binary Stdout Contract check is inapplicable as no test code or stdout-producing code is involved.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only JSON release configuration files for OCP 4.23 and 5.0, not Ginkgo e2e tests. Check is not applicable.
No-Weak-Crypto ✅ Passed PR modifies only JSON configuration files with no cryptographic code, algorithms, or implementations. No MD5, SHA1, DES, RC4, or other weak crypto detected.
Container-Privileges ✅ Passed PR modifies only release configuration JSON files, not container/Kubernetes manifests. No privileged security configurations present.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only configuration files with secret names (not values) and repository references; no logging code added that could expose sensitive data.
Title check ✅ Passed The title 'Add referenceRelease to ci imagestreams for OCP 4.23 and 5.0' directly and clearly summarizes the main change: adding referenceRelease configuration to CI imagestreams for two specific OCP versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007 deepsm007 changed the title Add referenceRelease to ci imagestreams for OCP 4.23 and 5.0 DPTP-3787: Add referenceRelease to ci imagestreams for OCP 4.23 and 5.0 Jun 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: This pull request references DPTP-3787 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

openshift/ci-tools#5233

/cc @openshift/test-platform @bradmwilliams
/hold

Summary by CodeRabbit

This PR updates the OpenShift release controller configuration for OCP 4.23 and 5.0 CI builds to add reference release mirror configurations.

Changes made:

  • Modified core-services/release-controller/_releases/release-ocp-4.23-ci.json and release-ocp-5.0-ci.json to add referenceRelease configuration for the 4.23.0-0.ci and 5.0.0-0.ci releases respectively
  • Each updated file now specifies:
  • Push repository: quay.io/openshift/ci
  • Pull repository: quay-proxy.ci.openshift.org/openshift/ci
  • Mirror secret: release-controller-quay-mirror-secret
  • Reference mode: "source"

Impact:
These changes configure CI image mirroring for the release controller, enabling OCP 4.23 and 5.0 CI builds to use Quay mirror repositories for storing and retrieving container images during the release process. This complements the ci-tools changes referenced in the related PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants