Add CI config for stackrox OCP-ECR prefetcher branch by porridge · Pull Request #80286 · openshift/release

porridge · 2026-06-09T12:04:48Z

What

Add on-demand OCP 4.22 on AWS CI test jobs for the stackrox/stackrox
feature branch mowsiany/image-prefetcher-ocp-ecr, which enables
OCP-ECR kubelet image credential provider integration in the image
prefetcher.

The tests are configured as optional presubmits (always_run: false,
optional: true) so they only run when explicitly requested via
/test comments.

Companion PR: stackrox/stackrox#21031

Summary by CodeRabbit

This PR adds OpenShift CI configuration to the openshift/release repository to enable on-demand testing of the StackRox feature branch (stackrox/stackrox branch mowsiany/image-prefetcher-ocp-ecr) against OCP 4.22 on AWS.

What changed (practical impact)

Added a new ci-operator config file for the stackrox/stackrox mowsiany/image-prefetcher-ocp-ecr variant: ocp-4.22-lpMainline-lp-ocp-compat.
This file wires presubmit jobs that are optional and run only when explicitly triggered (always_run: false, optional: true), so the tests execute on demand via /test commands.

Tests / jobs added

Two optional presubmit variants configured to use the firewatch-ipi-aws-cr workflow and the stackrox-qa-e2e test ref:

cr--acs--tests-aws
- Runs ACS test suite on AWS (cluster_profile: aws-cspi-qe) for OCP 4.22.
- MAP_TESTS enabled.
- Test pod requests: cpu 8, memory 8000Mi.
- Firewatch failure rule: treat any failure from steps matching stackrox-* as "ACS Test Failure".
- Default JIRA: project ROX, assignee dahouse@redhat.com, additional labels include 4.22-lp-cr, self-managed-lp, acs-lp, interop-tests.
acs--tests-aws-fips
- Same as above but with FIPS_ENABLED=true and adjusted Firewatch rules:
  - pod_failure classified as "ACS Test Execution"
  - test_failure classified as "ACS Test Failure" and can fail the job (FIREWATCH_FAIL_WITH_TEST_FAILURES=true)
- Default JIRA: project LPINTEROP, assignee dahouse@redhat.com, labels include 4.22-lp, self-managed-lp, acs-lp, fips, interop-tests.

Build / image settings

base_images.ubi-minimal pinned to ocp:8.
build_root.image_stream_tag set to stackrox/apollo-ci:stackrox-ui-test-stable.
releases.latest.candidate set to ocp nightly for version 4.22.
test binary build commands set to .openshift-ci/dispatch.sh test-binary-build-commands.

Metadata

Generated metadata records branch mowsiany-image-prefetcher-ocp-ecr in org stackrox/repo stackrox for variant ocp-4.22-lpMainline-lp-ocp-compat.

This config enables on-demand AWS-based interoperability testing (including a FIPS variant) for the StackRox OCP–ECR image-credential-provider work when explicitly requested.

… branch Add on-demand OCP 4.22 on AWS test jobs for the feature branch that enables OCP-ECR kubelet image credential provider integration in the image prefetcher. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci · 2026-06-09T12:04:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-06-09T12:05:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/stackrox/OWNERS~~ [porridge]
~~ci-operator/jobs/stackrox/stackrox/OWNERS~~ [porridge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

porridge · 2026-06-09T12:05:48Z

/test all

coderabbitai · 2026-06-09T12:05:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0648a671-b0a6-47f2-99d2-566b1235e0f2

📥 Commits

Reviewing files that changed from the base of the PR and between cf01135 and 41673e6.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml

Walkthrough

Adds a new ci-operator YAML for the StackRox image prefetcher variant targeting OCP 4.22: pins base image and build root, sets test pod resource requests and build commands, defines two optional AWS test variants (standard and FIPS) with Firewatch and Jira defaults, and records generated metadata.

Changes

StackRox image prefetcher CI setup

Layer / File(s)	Summary
Base images and OCP release `ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml`	Defines `base_images` (ubi-minimal:8), sets `build_root.image_stream_tag`, and configures `releases.latest.candidate` for OCP 4.22 (nightly).
Pod resources and build commands `ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml`	Sets global test resource requests (`cpu: 8`, `memory: 8000Mi`) and `test_binary_build_commands` to `.openshift-ci/dispatch.sh test-binary-build-commands`.
AWS test workflows (standard and FIPS-enabled) `ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml`	Adds `cr--acs--tests-aws` and `acs--tests-aws-fips` variants with cluster profile, environment variables (including `FIPS_ENABLED` for FIPS variant), Firewatch failure rules, Jira defaults, and `firewatch-ipi-aws-cr` workflow using `stackrox-qa-e2e` tests.
Generated configuration metadata `ci-operator/config/stackrox/stackrox/stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr__ocp-4.22-lpMainline-lp-ocp-compat.yaml`	Appends `zz_generated_metadata` with branch/org/repo and the variant identifier.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

openshift/release#80227: Adds postsubmit image push job configuration for StackRox.

Suggested labels

rehearsals-ack

Suggested reviewers

vickeybrown
yuumasato
psav

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: adding CI configuration for the StackRox OCP-ECR prefetcher branch, which matches the file additions and PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds only YAML CI configuration files with no Ginkgo test definitions; check is not applicable to configuration-only changes.
Test Structure And Quality	✅ Passed	PR adds a CI configuration YAML file only, not Ginkgo test code, so this test structure check is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds CI config YAML only, not Ginkgo test code. Custom check for "new Ginkgo e2e tests" is not applicable to CI configuration files.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds only a CI configuration YAML file that references existing tests (stackrox-qa-e2e), not new Ginkgo test code. The custom check applies only to new test additions, not CI configuration changes.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds only a CI operator configuration file (not deployment manifests, operator code, or controllers). Contains no Kubernetes scheduling directives, affinity rules, or topology constraints.
Ote Binary Stdout Contract	✅ Passed	PR adds only CI configuration YAML files, no Go code that could violate the OTE Binary Stdout Contract check.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds only CI configuration YAML files (no Ginkgo test code). Actual tests referenced via 'stackrox-qa-e2e' are defined elsewhere in stackrox/stackrox repo.
No-Weak-Crypto	✅ Passed	PR adds CI configuration YAML files only, containing no cryptographic code, weak algorithms (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), custom crypto implementations, or insecure secret comparisons.
Container-Privileges	✅ Passed	No container privilege escalation settings found; YAML files do not contain privileged: true, hostPID/Network/IPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation: true.
No-Sensitive-Data-In-Logs	✅ Passed	CI config file contains no sensitive data exposed in logs. Email in FIREWATCH_DEFAULT_JIRA_ASSIGNEE follows established patterns in 139+ similar CI configs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

porridge · 2026-06-09T12:08:39Z

/pj-rehearse pull-ci-stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws

openshift-merge-bot · 2026-06-09T12:08:42Z

@porridge: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

porridge · 2026-06-09T16:20:18Z

/test all

openshift-merge-bot · 2026-06-09T16:23:30Z

[REHEARSALNOTIFIER]
@porridge: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips	stackrox/stackrox	presubmit	Presubmit changed
pull-ci-stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws	stackrox/stackrox	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

porridge · 2026-06-09T16:24:01Z

/pj-rehearse pull-ci-stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws

openshift-merge-bot · 2026-06-09T16:24:03Z

@porridge: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-06-09T19:32:34Z

@porridge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/stackrox/stackrox/mowsiany-image-prefetcher-ocp-ecr/ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws	`41673e6`	link	unknown	`/pj-rehearse pull-ci-stackrox-stackrox-mowsiany-image-prefetcher-ocp-ecr-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026

porridge mentioned this pull request Jun 9, 2026

fix(ci): use IfNotPresent pull policy for prefetched images on non-GKE stackrox/stackrox#20993

Open

5 tasks

autogen

41673e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI config for stackrox OCP-ECR prefetcher branch#80286

Add CI config for stackrox OCP-ECR prefetcher branch#80286
porridge wants to merge 2 commits into
openshift:mainfrom
porridge:mowsiany/stackrox-image-prefetcher-ocp-ecr

porridge commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

porridge commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Summary by CodeRabbit

What changed (practical impact)

Tests / jobs added

Build / image settings

Metadata

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

porridge commented Jun 9, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 9, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

porridge commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading