hypershift: add 5.0 HCM Azure AKS upgrade-minor periodic#80306
hypershift: add 5.0 HCM Azure AKS upgrade-minor periodic#80306bryan-cox wants to merge 2 commits into
Conversation
Add the periodics-hcm-azure variant for release-5.0, containing the e2e-aks-upgrade-minor test that upgrades from 4.22 to 5.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR adds a new hypershift periodic CI configuration file for OpenShift 5.0 on Azure with HCM. The configuration defines base/external image references, release candidate streams/versions, default resource requests, a scheduled e2e-aks-upgrade-minor workflow wired to hypershift-azure-aks-e2e with environment variables, and generated metadata. ChangesHyperShift Azure Periodic Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/test ? |
|
@bryan-cox: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-hcm-azure-e2e-aks-upgrade-minor |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| candidate: | ||
| product: ocp | ||
| stream: ci | ||
| version: "4.22" |
There was a problem hiding this comment.
The other HCM Azure periodic configs all use N-1 as the initial-minor (4.21→4.20, 4.22→4.21, 4.23→4.22). This one upgrades from 4.22→5.0 which is a two-minor jump. Is that intentional, or should this be 4.23 to stay consistent with the pattern?
I notice the existing release-5.0__periodics.yaml also uses 4.22 as its N-1, so maybe the team treats 4.22 as the predecessor to 5.0 — just want to make sure.
There was a problem hiding this comment.
Intentional — 4.22 is the correct predecessor for 5.0. Per Trevor (wking), there is no 4.23 → 5.0 upgrade path. 4.23 and 5.0 are parallel tracks (4.23 is essentially 5.0 with new features disabled), so the supported minor upgrade into 5.0 is from 4.22.
| cpu: 100m | ||
| memory: 200Mi | ||
| tests: | ||
| - as: e2e-aks-upgrade-minor |
There was a problem hiding this comment.
Minor nit: this is the same schedule as the 4.23 HCM Azure periodic. The other versions are staggered (4am, 5am, 7am, 9am). Might be worth offsetting to avoid competing for hypershift-aks leases at the same time — but not a blocker if it's intentional.
There was a problem hiding this comment.
Good catch — staggered to 11am UTC in the latest push to avoid competing for hypershift-aks leases.
Offset from the 4.23 job (9am) to avoid competing for hypershift-aks leases at the same time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-hcm-azure-e2e-aks-upgrade-minor |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
periodics-hcm-azurevariant forrelease-5.0, mirroring the existing 4.23 confige2e-aks-upgrade-minortest that upgrades from 4.22 to 5.0 using the HCM hypershift-operator image fromacm-dTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
This PR adds a new periodic CI configuration for the hypershift repo on the release-5.0 branch that mirrors the existing 4.23 HCM Azure setup. It introduces ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics-hcm-azure.yaml which registers a daily periodic job (cron 0 11 * * *) for the periodics-hcm-azure variant.
In practical terms the job:
The commit also staggers the 5.0 HCM Azure periodic to 11:00 UTC (offset from the 4.23 job) to avoid competing for hypershift-aks leases. The change is configuration-only and adds the periodic job to ensure minor-upgrade scenarios to OpenShift 5.0 on Azure are continuously validated.