ARO-HCP: use aro-hcp-e2e-tools image for write-config step#80312
ARO-HCP: use aro-hcp-e2e-tools image for write-config step#80312gmfrasca wants to merge 1 commit into
Conversation
write-config only needs templatize, which is in aro-hcp-e2e-tools. Using the heavier aro-hcp-e2e-tests image adds ~10 min of unnecessary cold-pull time to the critical path of every e2e job. Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gmfrasca The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis PR updates the CI step registry configuration for the ARO HCP write-config step. The ChangesCI Step Registry Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-Azure-ARO-HCP-main-e2e-parallel |
|
@gmfrasca: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@gmfrasca: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
The
write-configstep only runstemplatizeto render a partial config.yaml. It was recently moved to thearo-hcp-e2e-testsimage, which is significantly larger.Originally this was thought to improve pull-times, but after experimentation, the runtime difference has been deemed to be negligible (on the scale of seconds). With that said, the change itself is still sound - tooling-specific steps should use the
-toolsimage, not-tests.Test plan
e2e-paralleljobSummary by CodeRabbit
This PR optimizes the ARO-HCP CI infrastructure by reducing image pull time for a specific build step. The change updates the
write-configstep in the ARO-HCP e2e CI pipeline to use the smalleraro-hcp-e2e-toolscontainer image instead of the largeraro-hcp-e2e-testsimage.What changed:
ci-operator/step-registry/aro-hcp/write-config/aro-hcp-write-config-ref.yamlto referencearo-hcp-e2e-toolsas the base imageWhy this matters:
The
write-configstep only executes thetemplatizebinary to render a partialconfig.yamlfile. Previously, this step was using the largeraro-hcp-e2e-testsimage which cold-pulls in approximately 15 minutes. By switching to the smalleraro-hcp-e2e-toolsimage (which contains the neededtemplatizebinary and pulls in ~5 minutes), this eliminates a ~10-minute overhead from the critical path of every ARO-HCP e2e CI job. Since ci-operator step pods don't share node-level image caches, this change directly improves job execution time.Testing:
The author plans to validate with pj-rehearsal on the
e2e-paralleljob (pending completion).