add session as an argument for openski api#36
Closed
fcomuniz wants to merge 1 commit intoopenskynetwork:masterfrom
Closed
add session as an argument for openski api#36fcomuniz wants to merge 1 commit intoopenskynetwork:masterfrom
fcomuniz wants to merge 1 commit intoopenskynetwork:masterfrom
Conversation
Collaborator
|
I am going to use a requests session in my PR while migrating to oauth2. What benefit do you see on providing your own session object? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for a custom session when using requests, where we may be able to configure more parameters