Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class support for CloudFormation AWS::RDS::DBCluster resources (Aurora) to the OpenStax AWS Ruby helpers, enabling callers (e.g., unified-deployment) to change an Aurora cluster master password when restoring from snapshots.
Changes:
- Introduces
OpenStax::Aws::RdsClusterwithset_master_password. - Registers
AWS::RDS::DBClusterinResourceFactoryand requires the new wrapper in the library entrypoint. - Adds an RSpec covering the password-change behavior; updates spec helper to load
OpenStruct.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/spec_helper.rb | Ensures OpenStruct is available across specs; normalizes dotenv require. |
| spec/rds_cluster_spec.rb | Adds a unit spec asserting set_master_password calls through to the SDK resource. |
| lib/openstax_aws.rb | Loads the new RDS cluster wrapper as part of the gem entrypoint. |
| lib/openstax/aws/resource_factory.rb | Maps AWS::RDS::DBCluster to OpenStax::Aws::RdsCluster for stack resource instantiation. |
| lib/openstax/aws/rds_cluster.rb | Implements the Aurora DBCluster wrapper and set_master_password. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jivey
approved these changes
Apr 14, 2026
| require 'dotenv/load' | ||
| require "byebug" | ||
| require "dotenv/load" | ||
| require "ostruct" |
Member
There was a problem hiding this comment.
Is this not included in default gems anymore? I haven't kept up with ruby news.
Member
Author
There was a problem hiding this comment.
Since some ruby version (not sure which), it seems we need to require "ostruct" to use OpenStruct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unified-deployment needs this so we can call set_master_password when a snapshot is present