Skip to content

Fix tests for issue 972 previous template idea #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiotrKozlowski wants to merge 9 commits into
base: issue-972-previous-template-idea
Choose a base branch
from
Open

Fix tests for issue 972 previous template idea #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2edb59c
Fix typos in secrets.rb
Jun 12, 2020
c453985
Fix tests / update cassettes for secrets
Jun 12, 2020
93c2a3d
Update cassettes for stacks
Jun 12, 2020
f874de7
@changed_secrets are initialy Nil
Jun 12, 2020
381a09c
Add simple test for reverting secrets
Jun 12, 2020
4a16cd8
If Template was created from the response body then there is no absol…
Jun 16, 2020
7f64690
Update cassette for reverts_to_previous_change_set
Jun 16, 2020
d8ad4a6
Replace test for reverting to previous change set with test for rever…
Jun 16, 2020
25ad40c
Move old_value parameter outside of mock value
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/openstax/aws/secrets.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def update(specifications: nil, substitutions: nil, force_update_these: [])
OpenStax::Aws.logger.info("Secrets did not change")
return false
else
OpenStax::Aws.logger.info("Updating the following secrets in the AWS parameter store: #{changed_secrets}")
OpenStax::Aws.logger.info("Updating the following secrets in the AWS parameter store: #{@changed_secrets}")

# Ship 'em
if !dry_run
Expand All @@ -80,7 +80,7 @@ def update(specifications: nil, substitutions: nil, force_update_these: [])
end

def revert
if @changed_secrets.empty?
if !@changed_secrets || @changed_secrets.empty?
OpenStax::Aws.logger.info("Secrets did not change during the last update, so there is nothing to revert")
else
reverted_secrets = @changed_secrets.map do |changed_secret|
Expand Down Expand Up @@ -119,7 +119,7 @@ def self.changed_secrets(existing_secrets_hash, new_secrets_array)
end

# Keep the old value around in case we need to revert it
new_secrets[:old_value] = existing_secret[:value]
new_secret[:old_value] = existing_secret ? existing_secret[:value] : nil

array.push(new_secret)
end
Expand Down
2 changes: 1 addition & 1 deletion lib/openstax/aws/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def self.from_body(body)
end

def basename
File.basename(absolute_file_path)
File.basename(absolute_file_path) if absolute_file_path
end

def body
Expand Down
Loading