UCP/CORE: Support negate mode for device selection environment variables#11167
Merged
brminich merged 24 commits intoopenucx:masterfrom Feb 23, 2026
Merged
UCP/CORE: Support negate mode for device selection environment variables#11167brminich merged 24 commits intoopenucx:masterfrom
brminich merged 24 commits intoopenucx:masterfrom
Conversation
698da1c to
1b943b6
Compare
tvegas1
reviewed
Feb 4, 2026
8128848 to
885b827
Compare
tvegas1
reviewed
Feb 9, 2026
ColinNV
reviewed
Feb 11, 2026
brminich
reviewed
Feb 11, 2026
tvegas1
previously approved these changes
Feb 12, 2026
aa0a235 to
a4cd789
Compare
brminich
reviewed
Feb 13, 2026
tvegas1
previously approved these changes
Feb 16, 2026
brminich
previously approved these changes
Feb 16, 2026
ColinNV
approved these changes
Feb 17, 2026
yosefe
reviewed
Feb 18, 2026
fb57934
brminich
approved these changes
Feb 20, 2026
tvegas1
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Changed
UCX_*_DEVICESenvironment variables (NET_DEVICES,SHM_DEVICES,ACC_DEVICES,SELF_DEVICES) from string arrays to allow lists, enabling negate mode with the^prefix syntax (e.g.,UCX_NET_DEVICES=^mlx5_0).Why?
Align behavior with other env variables such as
UCX_TLSandUCX_PROTOSthat already support the negate syntax.How?
UCS_CONFIG_TYPE_STRING_ARRAYtoUCS_CONFIG_TYPE_ALLOW_LISTucp_is_resource_in_device_list()to handle ALLOW_ALL and NEGATE modes