UCT/IB: fix ddp for dv qp#11174
Merged
yosefe merged 3 commits intoopenucx:masterfrom Feb 28, 2026
Merged
Conversation
yosefe
reviewed
Feb 14, 2026
Comment on lines
+622
to
+624
| if (!(md->flags & (UCT_IB_MLX5_MD_FLAG_DEVX_RC_QP | | ||
| UCT_IB_MLX5_MD_FLAG_DEVX_DCT | | ||
| UCT_IB_MLX5_MD_FLAG_DEVX_DCI))) { |
Contributor
There was a problem hiding this comment.
IMO we can check (and set) iface->config.ddp_enabled_dv without this check. so the function uct_rc_mlx5_dp_ordering_ooo_init will initialize both iface->config.ddp_enabled_dv (for dv) and iface->config.dp_ordering_devx/force (for devx), regardless of the devx flags on md->flags.
we can drop the error in line 626, since for DevX case there is no equivalent of this error anyway
yosefe
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix ddp flag issue for dv qps.
Why?
Currently, in the master branch, the ddp dv capacity is only checked when devx is not supported.
This does not address scenarios where devx is supported but devx qp is unsupported/disabled.