feat: add floor heating + room control#557
Conversation
|
Hi @Roguyt, I came across this PR while working on related PyViCare changes. Nice work — the room control API surface is well covered (sensors, heating/cooling programs, schedules, quick modes) and having real device test data for 6 rooms is very helpful. Are you still working on this? I'd be happy to help get it across the finish line if you want. A few things I noticed while reading through the diff:
None of these are blockers, just things that stood out. Let me know if you'd like a hand with the conflict resolution or any of the above. |
|
@CFenner I just came across the discussion in the ViCare Discord about rooms and your reaction to it. I hadn't seen that before. I understand the HA team doesn't want rooms mapped as devices, but looking at the test data here, the sensor readings (temperature, humidity, CO2) are only available on the RoomControl virtual device under A few approaches come to mind:
What's your thinking on this? I'd be happy to help move it forward once we know the direction. |
|
Hey, I had in mind to go with 2., exposing the temp (get/set) on the device via the room control. |
No description provided.