Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes leftover FIXME comments in test model constants and the Mistral LLM tool parser, aligning the codebase with the referenced CVS-183878 cleanup.
Changes:
- Deleted an unused
FIXME-commented-out shape constant insrc/test/test_models.hpp. - Deleted a
FIXMEnote about duplicated logic insrc/llm/io_processing/mistral/tool_parser.hpp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/test/test_models.hpp |
Removes an obsolete FIXME comment in test model shape constants. |
src/llm/io_processing/mistral/tool_parser.hpp |
Removes a FIXME duplication note above streaming parser state members. |
atobiszei
approved these changes
Mar 31, 2026
rasapala
approved these changes
Mar 31, 2026
michalkulakowski
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-183878