Skip to content

Remove fixme CVS-183878#4104

Merged
dkalinowski merged 1 commit intomainfrom
removefixme
Apr 2, 2026
Merged

Remove fixme CVS-183878#4104
dkalinowski merged 1 commit intomainfrom
removefixme

Conversation

@dkalinowski
Copy link
Copy Markdown
Collaborator

🛠 Summary

CVS-183878

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes leftover FIXME comments in test model constants and the Mistral LLM tool parser, aligning the codebase with the referenced CVS-183878 cleanup.

Changes:

  • Deleted an unused FIXME-commented-out shape constant in src/test/test_models.hpp.
  • Deleted a FIXME note about duplicated logic in src/llm/io_processing/mistral/tool_parser.hpp.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/test_models.hpp Removes an obsolete FIXME comment in test model shape constants.
src/llm/io_processing/mistral/tool_parser.hpp Removes a FIXME duplication note above streaming parser state members.

@dkalinowski dkalinowski merged commit 0781ad5 into main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants