Skip to content

[qa] Add --ignore-pattern option to exclude files from QA checks #299#461

Closed
aoutifrak wants to merge 8 commits intoopenwisp:masterfrom
aoutifrak:ignore-files-qa-check-299
Closed

[qa] Add --ignore-pattern option to exclude files from QA checks #299#461
aoutifrak wants to merge 8 commits intoopenwisp:masterfrom
aoutifrak:ignore-files-qa-check-299

Conversation

@aoutifrak
Copy link
Copy Markdown
Contributor

@aoutifrak aoutifrak commented Apr 1, 2025 •
edited
Loading

  • Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories.
  • Supports ignoring patterns like node_modules and env, which are unnecessary for QA checks.
  • Ensured compatibility with existing QA check functionality.

This enhancement provides flexibility in excluding non-essential files

Fixes #299

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #.

Please open a new issue if there isn't an existing issue yet.

Description of Changes

Please describe these changes.

Screenshot

Please include any relevant screenshots.

devkapilbansal
devkapilbansal requested changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @aoutifrak,
Please address the comments below. Also, comments should be added to explain why a change in done instead of what is done. Please avoid comments where they are not necessary

Comment thread openwisp-qa-check Outdated
Comment thread openwisp-qa-check Outdated
Comment thread openwisp-qa-check
aoutifrak
aoutifrak commented Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@aoutifrak aoutifrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are made

@aoutifrak aoutifrak requested a review from devkapilbansal April 2, 2025 17:38
@aoutifrak aoutifrak force-pushed the ignore-files-qa-check-299 branch 2 times, most recently from 6424226 to 910931d Compare April 2, 2025 18:06
codesankalp
codesankalp requested changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@codesankalp codesankalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 , It will need some more modifications. please have a look at the comments below and give it a try with different scenarios.

Comment thread openwisp-qa-check
Comment thread openwisp-qa-check Outdated
Comment thread openwisp-qa-check
Comment thread openwisp-qa-check
@codesankalp
Copy link
Copy Markdown
Member

codesankalp commented Apr 2, 2025

Also, please remove trailing whitespaces from your changes.

@aoutifrak aoutifrak force-pushed the ignore-files-qa-check-299 branch from e4d7b65 to 910931d Compare April 2, 2025 19:04
@aoutifrak aoutifrak requested a review from codesankalp April 2, 2025 19:05
devkapilbansal
devkapilbansal requested changes Apr 3, 2025
View reviewed changes
Comment thread openwisp-qa-check Outdated
@aoutifrak aoutifrak force-pushed the ignore-files-qa-check-299 branch from 5d53376 to 910931d Compare April 3, 2025 18:08
@aoutifrak aoutifrak requested a review from devkapilbansal April 3, 2025 18:10
devkapilbansal
devkapilbansal requested changes Apr 3, 2025
View reviewed changes
Comment thread openwisp-qa-check
@aoutifrak aoutifrak requested a review from devkapilbansal April 3, 2025 19:29
devkapilbansal
devkapilbansal requested changes Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoutifrak Looks good, but the tests for this are missing. Kindly add relevant test cases also

@aoutifrak @devkapilbansal
[qa] Add --ignore-pattern option to exclude files from QA checks open…
e198e47 
…wisp#299

- Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories.
- Supports ignoring patterns like node_modules and env, which are unnecessary for QA checks.
- Ensured compatibility with existing QA check functionality.

This enhancement provides flexibility in excluding non-essential files

Fixes openwisp#299
@aoutifrak @devkapilbansal
[qa] Add --ignore-pattern option to exclude files from QA checks open…
ecc72c1 
…wisp#299

- Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories.

Fixes openwisp#299
@aoutifrak @devkapilbansal
[qa] Add --ignore-pattern option to exclude files from QA checks open…
792dddf 
…wisp#299

- Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories.
- Supports ignoring patterns like node_modules and env, which are unnecessary for QA checks.
- Ensured compatibility with existing QA check functionality.

This enhancement provides flexibility in excluding non-essential files

Fixes openwisp#299
@devkapilbansal devkapilbansal force-pushed the ignore-files-qa-check-299 branch from 08b97d2 to 792dddf Compare April 11, 2025 18:37
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 11, 2025 •
edited
Loading

Coverage Status

coverage: 95.981%. remained the same
when pulling 813f097 on aoutifrak:ignore-files-qa-check-299
into cfbd63e on openwisp:master.

@aoutifrak aoutifrak requested a review from devkapilbansal May 12, 2025 18:15
@openwisp-companion
Copy link
Copy Markdown

openwisp-companion Bot commented Mar 9, 2026

Hi @aoutifrak 👋,

This pull request has been automatically closed due to 239 days of inactivity. After changes were requested, the PR remained inactive.

We understand that life gets busy, and we appreciate your initial contribution! 💙

The door is always open for you to come back:

  • You can reopen this PR at any time if you'd like to continue working on it
  • Feel free to push new commits addressing the requested changes
  • If you reopen the PR, the linked issue will be reassigned to you

If you have any questions or need help, don't hesitate to reach out. We're here to support you!

Thank you for your interest in contributing to OpenWISP! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codesankalp codesankalp Awaiting requested review from codesankalp

@devkapilbansal devkapilbansal Awaiting requested review from devkapilbansal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[change] Add an option to ignore files in openwisp-qa-check

4 participants

@aoutifrak @codesankalp @coveralls @devkapilbansal