Skip to content

fix(prefs): remove obsolete Firefox preferences#1140

Draft
vringar wants to merge 1 commit intomasterfrom
fix/obsolete-firefox-prefs
Draft

fix(prefs): remove obsolete Firefox preferences#1140
vringar wants to merge 1 commit intomasterfrom
fix/obsolete-firefox-prefs

Conversation

@vringar
Copy link
Copy Markdown
Contributor

@vringar vringar commented Feb 23, 2026

Summary

  • Remove 27 Firefox preferences that no longer exist in modern Firefox (v147+), verified against mozilla-central via searchfox.org
  • Fix typo: browser.safebrowsing.phising.enabled -> browser.safebrowsing.phishing.enabled
  • Clean up stale comments

Closes #1060

Changes

  • openwpm/deploy_browsers/configure_firefox.py: Remove obsolete prefs, fix typo, update comments

Removed preferences (categories)

  • Startup: browser.slowStartup.*, extensions.checkCompatibility.nightly, dom.flyweb.enabled
  • Plugins (NPAPI removed): dom.ipc.plugins.*
  • Telemetry: browser.selfsupport.url
  • Search/Location: browser.urlbar.userMadeSearchSuggestionsChoice, browser.casting.enabled, browser.search.countryCode, browser.search.geoSpecificDefaults*
  • Updates: app.update.enabled, lightweightThemes.update.enabled
  • Experiments: experiments.*, network.allow-experiments
  • New Tab: browser.newtabpage.directory.*, browser.newtabpage.enhanced, browser.newtabpage.introShown, browser.aboutHomeSnippets.updateUrl
  • Shield: extensions.shield-recipe-client.enabled

Test plan

  • Run full test suite to verify no regressions
  • Verify Firefox starts correctly with updated preferences

@vringar vringar force-pushed the fix/obsolete-firefox-prefs branch from aa66982 to 401b02f Compare February 26, 2026 23:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.90%. Comparing base (58218c7) to head (48faa06).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   62.16%   61.90%   -0.26%     
==========================================
  Files          40       40              
  Lines        3898     3872      -26     
==========================================
- Hits         2423     2397      -26     
  Misses       1475     1475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vringar vringar force-pushed the fix/obsolete-firefox-prefs branch from 401b02f to adc2fca Compare March 2, 2026 23:20
…x.py

Remove preferences that no longer exist in modern Firefox (v147+),
verified against mozilla-central via searchfox.org.

Removed preferences (no longer in Firefox source):
- browser.slowStartup.{notificationDisabled,maxSamples,samples}
- extensions.checkCompatibility.nightly
- dom.flyweb.enabled (FlyWeb feature removed)
- dom.ipc.plugins.{reportCrashURL,flash.subprocess.crashreporter.enabled}
  (NPAPI plugin support removed)
- browser.selfsupport.url
- browser.urlbar.userMadeSearchSuggestionsChoice
- browser.casting.enabled
- browser.search.countryCode
- browser.search.geoSpecificDefaults{,.url}
- app.update.enabled
- lightweightThemes.update.enabled (Personas/lightweight themes removed)
- experiments.{enabled,manifest.uri,supported,activeExperiment}
- network.allow-experiments
- browser.newtabpage.{directory.ping,directory.source,enhanced,introShown}
- browser.aboutHomeSnippets.updateUrl
- extensions.shield-recipe-client.enabled (replaced by Normandy)

Also fixed:
- browser.safebrowsing.phising.enabled -> phishing.enabled (typo fix)
- Minor comment improvements

Closes #1060
@vringar vringar force-pushed the fix/obsolete-firefox-prefs branch from adc2fca to 48faa06 Compare March 28, 2026 19:05
vringar added a commit that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up preferences set in configure_firefox.py

1 participant