Avoid grace period delay #7033
Open
Avoid grace period delay #7033
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell script does not propagate the SIGTERM signal that is sent to the pod when it is terminated; to avoid this, we run the last command to substitute the shell process, so that the pod stop immediately instead of waiting the 30 default seconds of the grace period when an user uninstall the operator by using 'operator-sdk cleanup ...' command. Signed-off-by: Alejandro Visiedo <learning.little.engineer.2025.1@gmail.com>
Make registry-server run with pid 1, after initialization so when the container is stopped, the process is gracefully terminated. Signed-off-by: Alejandro Visiedo <learning.little.engineer.2025.1@gmail.com>
Author
|
Related: #5866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The change proposed run the last command using
exec ...sothe last command in the chain is assigned the pid 1 in the container,
so when the container is stopped, that last process receive directly the
SIGTERM signal.
In my environment, I have observed a difference about 60 seconds
between run
make test-e2efor the master branch, and the branchwith this changes, more specific (could be more, as one test is failing
on my environment):
I am sure about the impact of the first commit, but unsure about the impact
of the second commit, but I have added to keep consistency. If I were missing
additional places where similar scenario could happens, I am happy to add additional
commits.
Motivation for the change:
It was observed the command for two containers are executed as
child of the shell interpreter. When the container receive the SIGTERM
the signal would no be propagated to the child process by the shell
interpreter. This would evoke a delay until the grace termination
timeout is reached when those containers are stopped.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs