Update dev hocuspocus compose image version and env#22019
Conversation
akabiru
force-pushed
the
maintenance/hocuspocus
branch
from
c56d6c1 to
01dd9cd
Compare
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
There's one more thing that we can probably also remove - would be nice if you could check that (see comment).
| - gateway | ||
| environment: | ||
| - ALLOWED_DOMAINS=openproject.${OPENPROJECT_DOCKER_DEV_TLD:-local},localhost | ||
| - NODE_TLS_REJECT_UNAUTHORIZED=0 |
There was a problem hiding this comment.
Do we still need the NODE_TLS_REJECT_UNAUTHORIZED? I thought this was legacy as well, but I could be mistaken.
There was a problem hiding this comment.
Ah, good eye- I'll double check as I recall it was needed at some point. Unless @brunopagno can answer. 😅
There was a problem hiding this comment.
AFAICT, this is still needed to workaround TLS in dev- I reckon we should be able to resolve this somehow with step/traefik? Not sure cc @NobodysNightmare @Kharonus
There was a problem hiding this comment.
So let me take a guess on what your problem might have been: A typical problem for our dev stack is that we work with self-signed certificates. Since these are not globally trusted, you need to tell your clients to trust them.
If I had to guess, then maybe you didn't manage to convince Hocuspocus to trust those self-signed certificates.
There was a problem hiding this comment.
If I had to guess, then maybe you didn't manage to convince Hocuspocus to trust those self-signed certificates.
This sounds like it Jan, thanks! I'll see if it's a "quick" fix or not 👍🏾
There was a problem hiding this comment.
I could not find time to address this yet. Merging the current refinement.
|
Thanks for taking care to improve this! |
* Remove deprecated `ALLOWED_DOMAINS` * Point to `openproject/hocuspocus:dev-lates` by default
akabiru
force-pushed
the
maintenance/hocuspocus
branch
from
01dd9cd to
f1a8906
Compare
3 participants
ALLOWED_DOMAINSopenproject/hocuspocus:dev-latesby default