Conversation
Owner
opficdev
commented
Mar 30, 2026
opficdev
commented
- closed ToooList의 헤더가 보이지 않는 현상을 해결한다 #334
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the header height logic in TodoListView.swift by removing dynamic height tracking via GeometryReader and replacing it with a static calculation based on the body font's line height. A review comment was provided suggesting that the hardcoded magic number 20 used in the height calculation be replaced with a named constant to improve maintainability and clarity.
| .scrollDisabled(!isScrollTrackingEnabled) | ||
| .contentMargins(.leading, 16, for: .scrollContent) | ||
| .frame(height: headerHeight) | ||
| .frame(height: UIFont.preferredFont(forTextStyle: .body).lineHeight.rounded(.up) + 20) |
Contributor
There was a problem hiding this comment.
하드코딩된 값 20은 헤더의 높이를 결정하는 중요한 값입니다. 이 값은 adaptiveButtonStyle의 패딩(상하 8pt씩 총 16pt)과 추가 여백(4pt)으로 계산된 것으로 보입니다. 가독성과 유지보수성을 위해 이 값을 headerVerticalPadding과 같은 이름의 상수로 정의하고, 주석으로 산출 근거를 남기는 것을 권장합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.