[#344] Firestore의 undo 작업에 대해 DB I/O 빈도수를 개선한다#346
Merged
Conversation
Owner
opficdev
commented
Apr 1, 2026
opficdev
commented
- closed Firestore의 undo 작업에 대해 DB I/O 빈도수를 개선한다 #344
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 요청은 Todo, WebPage, PushNotification에 soft delete 기능을 도입하고, 이를 주기적으로 정리하는 클린업 함수와 Firestore 경로 관리 유틸리티를 추가했습니다. 주요 피드백으로, 클린업 함수에서 사용하는 collectionGroup 쿼리에 필요한 COLLECTION_GROUP 스코프 인덱스가 firestore.index.json에 누락되어 있어 런타임 에러가 발생할 위험이 지적되었습니다. 특히 isDeleted 필드를 포함한 복합 인덱스 구성이 필요합니다.
Comment on lines
+82
to
84
| .where("isDeleted", "==", true) | ||
| .orderBy(admin.firestore.FieldPath.documentId()) | ||
| .limit(QUERY_BATCH_SIZE); |
Contributor
There was a problem hiding this comment.
collectionGroup("todoLists").where("isDeleted", "==", true).orderBy(FieldPath.documentId()) 쿼리는 isDeleted와 __name__ 필드에 대한 COLLECTION_GROUP 스코프의 복합 인덱스를 필요로 합니다. 현재 firestore.index.json에는 해당 조건의 인덱스가 누락되어 있어 스케줄러 실행 시 에러가 발생할 가능성이 높습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.