Conversation
Owner
opficdev
commented
Apr 6, 2026
- closed PushNotificationListView의 헤더에서 토글 형태의 필터링 버튼을 탭했을 시 불필요한 애니메이션이 렌더링되는 현상을 해결한다 #366
Contributor
There was a problem hiding this comment.
Code Review
이번 PR에서는 PushNotificationListView의 초기화 로직을 정리하고 헤더 뷰의 레이아웃 및 버튼 동작 방식을 수정했습니다. 리뷰 결과, UIFont를 직접 사용하여 높이를 계산하는 방식은 Dynamic Type 대응에 취약하므로 @ScaledMetric이나 패딩 활용을 권장하며, 애니메이션 억제를 위해 사용된 DispatchQueue.main.async 대신 SwiftUI의 의도에 맞는 withAnimation(.none)을 사용하도록 개선이 필요합니다.
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| } | ||
| } | ||
| .frame(height: UIFont.preferredFont(forTextStyle: .body).lineHeight.rounded(.up) + 20) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.