[#571] PushNotificationSettingsView에 TCA를 적용한다#590
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the push notification settings screen from a custom ViewModel-based architecture to the Composable Architecture (TCA). It removes the legacy PushNotificationSettingsViewModel, introduces the new PushNotificationSettingsFeature reducer, updates PushNotificationSettingsView to bind to the TCA store, and adds corresponding unit tests. The review feedback recommends using TCA dependencies (@Dependency(\.calendar) and @Dependency(\.date)) instead of directly accessing Calendar.current and Date() to ensure the code remains fully testable and consistent with TCA best practices.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
📸 영상 / 이미지 (Optional)