[#573] SettingsView에 TCA를 적용한다#591
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 기존의 SettingsViewModel을 Composable Architecture(TCA) 기반의 SettingsFeature로 리팩터링하고 관련 뷰와 테스트 코드를 업데이트합니다. 리뷰 피드백으로는 SettingsFeature 내에서 실제 사용되지 않는 중복 액션 및 분기 처리를 제거하여 코드를 정리할 것과, 불필요한 리소스 소모를 방지하기 위해 네트워크 및 테마 관찰 시작 시점을 코디네이터 초기화 단계에서 SettingsView의 onAppear 시점으로 이동할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
BindingAction기반$settingsStore.theme연결로 유지SettingsFeatureTestDoubles로 use case spy 분리📸 영상 / 이미지 (Optional)