[#574] SearchView에 TCA를 적용한다#592
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀리퀘스트는 기존의 SearchViewModel을 Composable Architecture(TCA) 기반의 SearchFeature로 마이그레이션하고, 관련된 뷰 및 테스트 코드를 업데이트하는 변경사항을 포함하고 있습니다. 또한 여러 피처에서 얼럿 생성 등의 헬퍼 메서드들을 static으로 변경하여 리팩토링을 진행했습니다. 리뷰어 피드백 중 LoginFeature에서 로그인 성공 시 로딩 상태가 해제되지 않아 UI가 멈출 수 있는 버그를 지적한 코멘트는 유효하므로 유지합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
📸 영상 / 이미지 (Optional)