[#575] TodoEditorView에 TCA를 적용한다#593
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 기존의 TodoEditorViewModel을 Composable Architecture(TCA) 기반의 TodoEditorFeature 리듀서로 마이그레이션하고, 이에 맞춰 TodoEditorView 및 관련 뷰와 코디네이터들을 업데이트하며 테스트 코드를 추가하는 변경사항을 담고 있습니다. 리뷰어는 SwiftUI 렌더링 클로저 내에서 Store를 직접 생성하여 상태 초기화나 이펙트 취소 버그가 발생할 수 있는 부분을 지적하며 자식 상태로 통합할 것을 권장했습니다. 또한, 비동기 마크다운 해석 이펙트(resolveMarkdownEffect)에서 발생할 수 있는 레이스 컨디션을 방지하기 위해 .cancellable을 적용하도록 개선을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
TodoEditorFeature를 추가하고 TodoEditorView가 StoreOf를 사용하도록 변경함
🔍 상세
📸 영상 / 이미지 (Optional)