[#601] 푸시 알림 설정이 자동으로 upsert되는 현상을 해결한다#604
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR에서는 푸시 알림 설정 조회 시 서버 상태를 반영하는 로직을 applyFetchedSettings 액션으로 분리하여 바인딩 루프를 방지하고, 관련 테스트 코드를 추가하였습니다. 또한 의존성 패키지 버전을 .exact로 고정하였습니다. 리뷰에서는 서버 설정을 반영할 때 timePicker가 이미 열려있을 경우 화면과 시트의 시간 불일치가 발생할 수 있으므로 state.timePicker?.time도 함께 업데이트하도록 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
binding액션으로 다시 전달되면서 의도치 않게 푸시 알림 설정 업데이트가 발생하던 문제 해결📝 작업 내용
📌 요약
fetchSettings결과 반영 경로를binding액션과 별도 액션으로 분리한 작업🔍 상세
PushNotificationSettingsFeature에applyFetchedSettings액션 추가.binding(.set(...))대신applyFetchedSettings로 반영하도록 변경binding(\.pushNotificationEnable)에서만 업데이트 effect가 실행되도록 수정PushNotificationSettingsFeatureTests에 fetch 결과 반영 중 update use case 재호출이 발생하지 않는 테스트 추가📸 영상 / 이미지 (Optional)