[#577] PushNotificationListView에 TCA를 적용한다#605
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 푸시 알림 목록 화면을 TCA(The Composable Architecture) 기반의 PushNotificationListFeature로 마이그레이션하고, 기존 TodoListFeature 및 SearchFeature 액션들을 StoreAction으로 그룹화하는 리팩토링을 포함합니다. 리뷰 피드백으로는 알림 목록이 비어 있을 때 List 내부 분기 대신 비스크롤형 뷰를 사용하여 빈 화면을 처리할 것과, toggleRead 액션의 낙관적 업데이트 실패 시 상태를 되돌릴 수 있는 롤백 로직을 추가할 것을 제안합니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
Text분기에서List내부 row 방식으로 변경하여 헤더 재마운트에 따른 깜빡임 완화Picker를TodoListFeature와 동일하게 root binding 방식으로 정리store(StoreAction)로 분리store(StoreAction)로 분리📸 영상 / 이미지 (Optional)