Add macOS auto-update publishing and runtime checks#97
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
flashtype-website | ce00098 | Commit Preview URL Branch Preview URL |
Jun 12 2026, 01:31 AM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 545008be14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| release/*.dmg | ||
| release/*.zip | ||
| release/*.zip.blockmap | ||
| release/latest-mac.yml |
There was a problem hiding this comment.
In this workflow, the build step still runs pnpm run package:mac, whose script is electron-builder --mac --publish never (package.json:15). The electron-builder CLI docs define never as “never publish”, and the auto-update docs place latest-mac.yml generation/upload in the publish flow; this newly listed glob therefore has no manifest to attach for tag releases, leaving the new runtime updater without the channel file it queries. Use the publishing build path (or otherwise explicitly generate the metadata) before attaching latest-mac.yml.
Useful? React with 👍 / 👎.
| if (!app.isPackaged || process.env.FLASHTYPE_DISABLE_AUTO_UPDATE === "1") { | ||
| return; |
There was a problem hiding this comment.
For the macOS artifacts this enables, electron-builder.yml still sets mac.identity: null and the release workflow's signature verification is diagnostic/continue-on-error, so releases can be unsigned. Electron-updater's macOS support requires a signed app, so in those releases this path can download an update and show the Restart prompt, but Squirrel.Mac will reject the install. Gate setupAutoUpdates() to signed builds or make signing a required part of the release before enabling it.
Useful? React with 👍 / 👎.
1 participant
No description provided.