[codex] Guard markdown widget file handling#98
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
flashtype-website | fd1ddda | Commit Preview URL Branch Preview URL |
Jun 12 2026, 01:14 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes
Note
Low Risk
Defensive UI and key-value sync changes with fail-closed behavior; low risk aside from users no longer having non-markdown files treated as the active markdown document.
Overview
Adds shared
isMarkdownFilePathdetection and uses it so only markdown paths get the TipTap editor andflashtype_active_file_idupdates.Non-markdown file tabs still open in the central panel but show an unsupported-file placeholder (no editor mount, no raw content shown) so binary/CSV formatting is not corrupted. The shell derives the active markdown file via
activeMarkdownFileIdFromWidgetInstance, which requires a markdownfilePathand ignores other file widgets. Files drag-and-drop and copy now reuse the same path check; GitHub issue links point at the general issues page.Tests cover path helpers, placeholder/sync behavior, and opening CSV as a file widget tab.
Reviewed by Cursor Bugbot for commit fd1ddda. Bugbot is set up for automated code reviews on this repo. Configure here.