Skip to content

Conversation

@melcorr
Copy link
Contributor

@melcorr melcorr commented Dec 24, 2025

Recently I walked through all the image-builder workflows. Because the docs had the composer-cli steps, I used this and thought that image-builder CLI wasn't available. Then Justin Sherrill told me I could actually use image-builder CLI.

From my perspective, using image-builder CLI was an immediate, positive improvement to the workflow. It would be good for anyone interested to enjoy the image-builder CLI as soon as possible.

I marked this as draft because I am worried about this section:

https://github.com/osbuild/osbuild.github.io/compare/main...melcorr:osbuild.github.io:ibcli-doc-updates?expand=1#diff-69e48e37a22a2d556c2f023b7f62fbe1ed7ae365f0484fbecc7810dd5e715e42R58

Edit: I have included both sets of commands everywhere that I could test them.

I was walking through the steps on a Fedora 43 VM in UTM on my Mac. I had no means with which to test the cloud options.

To the best of my ability, this is now ready for review. Am happy to make any changes but this can be parked if people think it is too premature to merge at the moment.

@melcorr
Copy link
Contributor Author

melcorr commented Dec 30, 2025

OK - I have kept all the composer-cli steps.
I have one more page to do. I need to walk through and validate the steps.
This will be ready for review tomorrow.

@melcorr
Copy link
Contributor Author

melcorr commented Dec 31, 2025

I've gone through all of the docs, but I cannot myself test and reproduce valid steps for this page https://osbuild.org/docs/on-premises/commandline/edge-container+installer/

So other than correcting a typo, I will leave it out of this PR.

@melcorr melcorr marked this pull request as ready for review December 31, 2025 08:43
@melcorr melcorr requested a review from a team as a code owner December 31, 2025 08:43
@melcorr melcorr requested review from ochosi and schuellerf and removed request for a team December 31, 2025 08:43
ochosi
ochosi previously approved these changes Dec 31, 2025
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - this is a significant improvement ❤️

@ochosi ochosi enabled auto-merge (rebase) December 31, 2025 16:47
@ochosi ochosi disabled auto-merge December 31, 2025 16:47
@ochosi
Copy link
Contributor

ochosi commented Dec 31, 2025

Fuuuu... I created a merge commit. Stupid fat fingers 😮‍💨
@melcorr If you wanted to rebase locally on main and force push we could merge this right in

- Introduce the image-builder CLI somewhere
- Give equivalent steps for image-builder CLI
- Keep composer-cli steps for the moment
- Update typo in edge docs page
As suggested on PR by Michal Gold
@melcorr melcorr force-pushed the ibcli-doc-updates branch from cfc10e9 to 1cf658c Compare January 2, 2026 08:36
lzap
lzap previously approved these changes Jan 2, 2026
Co-authored-by: Lukáš Zapletal <lukas@zapletalovi.com>
@ochosi ochosi enabled auto-merge (rebase) January 2, 2026 23:01
@ochosi ochosi merged commit 92b9656 into osbuild:main Jan 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants