-
Notifications
You must be signed in to change notification settings - Fork 18
Update docs to reference image builder CLI #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f1a310 to
3aec955
Compare
|
OK - I have kept all the composer-cli steps. |
|
I've gone through all of the docs, but I cannot myself test and reproduce valid steps for this page https://osbuild.org/docs/on-premises/commandline/edge-container+installer/ So other than correcting a typo, I will leave it out of this PR. |
5cce34b to
518ee0e
Compare
ochosi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - this is a significant improvement ❤️
|
Fuuuu... I created a merge commit. Stupid fat fingers 😮💨 |
108e977 to
cfc10e9
Compare
- Introduce the image-builder CLI somewhere - Give equivalent steps for image-builder CLI - Keep composer-cli steps for the moment - Update typo in edge docs page
As suggested on PR by Michal Gold
cfc10e9 to
1cf658c
Compare
Co-authored-by: Lukáš Zapletal <lukas@zapletalovi.com>
Recently I walked through all the image-builder workflows. Because the docs had the composer-cli steps, I used this and thought that image-builder CLI wasn't available. Then Justin Sherrill told me I could actually use image-builder CLI.
From my perspective, using image-builder CLI was an immediate, positive improvement to the workflow. It would be good for anyone interested to enjoy the image-builder CLI as soon as possible.
I marked this as draft because I am worried about this section:
https://github.com/osbuild/osbuild.github.io/compare/main...melcorr:osbuild.github.io:ibcli-doc-updates?expand=1#diff-69e48e37a22a2d556c2f023b7f62fbe1ed7ae365f0484fbecc7810dd5e715e42R58
Edit: I have included both sets of commands everywhere that I could test them.
I was walking through the steps on a Fedora 43 VM in UTM on my Mac. I had no means with which to test the cloud options.
To the best of my ability, this is now ready for review. Am happy to make any changes but this can be parked if people think it is too premature to merge at the moment.