-
Notifications
You must be signed in to change notification settings - Fork 653
AO3-7246 Add Parent link to reply comments #5528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
AO3-7246 Add Parent link to reply comments #5528
Conversation
|
Regarding the rubocop test failure: Should I refactor the file to use |
|
Thanks for working on this! For larger pull requests, we usually ask people to restrict localization to changed lines. But this is a pretty small, straightforward change, so if you're willing, it would be terrific if you'd localize the whole file! I think the best place to put it would be under |
sarken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor, non-blocking change if you have the time -- thank you!
config/locales/views/en.yml
Outdated
| comment_actions: Comment Actions | ||
| parent: Parent | ||
| parent_thread: Parent Thread | ||
| reply_to_this: reply to this comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you capitalize the "r" here? All-lowercase text like this was an old stylistic choice that we're slowly eliminating.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7246
Purpose
Adds a "Parent" link button to reply / child comments, while also reordering the "Thread" and "Parent Thread" links.
Credit
Hunter Ada Smith (she/her)