Skip to content

Conversation

@hunternet93
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7246

Purpose

Adds a "Parent" link button to reply / child comments, while also reordering the "Thread" and "Parent Thread" links.

Credit

Hunter Ada Smith (she/her)

@hunternet93
Copy link
Contributor Author

Regarding the rubocop test failure:

Should I refactor the file to use t() instead of ts() for localization? If so, should I do so for the whole file, or just the changed lines? And would the strings go under [lang].comments.commentable in the YAML file, or elsewhere?

@sarken
Copy link
Collaborator

sarken commented Dec 31, 2025

Thanks for working on this!

For larger pull requests, we usually ask people to restrict localization to changed lines. But this is a pretty small, straightforward change, so if you're willing, it would be terrific if you'd localize the whole file!

I think the best place to put it would be under en.comments.comment_actions, similar to the way the text for the comment_form partial is under en.comments.comment_form.

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor, non-blocking change if you have the time -- thank you!

comment_actions: Comment Actions
parent: Parent
parent_thread: Parent Thread
reply_to_this: reply to this comment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you capitalize the "r" here? All-lowercase text like this was an old stylistic choice that we're slowly eliminating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants