Skip to content

AO3-7161 Add contents of recent comments a user left on the same work/adminpost to Akismet spam calls#5842

Open
omerfaruk-pseud wants to merge 26 commits into
otwcode:masterfrom
omerfaruk-pseud:AO3-7161
Open

AO3-7161 Add contents of recent comments a user left on the same work/adminpost to Akismet spam calls#5842
omerfaruk-pseud wants to merge 26 commits into
otwcode:masterfrom
omerfaruk-pseud:AO3-7161

Conversation

@omerfaruk-pseud
Copy link
Copy Markdown
Member

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7161

Purpose

Uses a method to fetch recent comments they left on the same work/adminpost to add the content of those to akismet_attributes. On controller, if a comment fails to save because it is spam, it checks for recent comments and mark those as spam too.

Credit

ömer faruk (he/him)

@omerfaruk-pseud
Copy link
Copy Markdown
Member Author

So, a couple of things:

  • The controller test is failing and I'm not sure why. When the post :create runs and subject.save returns false it should run the code and mark the old one as spam but it doesn't. My manual testing works though (when I force spam? to return true)
  • Is using parent instead of ultimate_parent fine? it is easier for sure. the only effect is for comments on different chapters so not that big of a deal?
  • Using pseud_id means you can bypass it via new pseuds, is there a way to check pseud.user without another query?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant