AO3-7482 Update "About Us" page and sitemap#5849
Conversation
There was a problem hiding this comment.
the variable names for links and their text should match, you currently have multiple of them that don't (e.g. archiving_software but github_repository_link). keep the names that match the link texts (e.g. archiving_software_link because its text says "archiving software")
the rest looks okay to me, but i've not confirmed that all of the text matches, someone with more attention to detail should also look this over
| contribute: contribute | ||
| description: The Archive of Our Own (AO3) is a non-profit, non-commercial fanwork archive for transformative fanworks; created by and for fans of books, music, art, games, shows, movies, real-person fiction (RPF), and other fandoms. | ||
| inclusiveness: maximum inclusiveness of fanwork content | ||
| inclusiveness_html: "<strong>AO3 is built upon the principle of %{inclusiveness_link}.</strong> Fanworks that do not violate the %{content_policy_link} or some other part of the %{tos_link} will not be removed from AO3, even if someone believes they are offensive or objectionable.</p>" |
There was a problem hiding this comment.
having html in the translation strings is strongly discouraged, you should probably split the bold and non-bold sentences into two strings
also there's an extra closing paragraph tag here
There was a problem hiding this comment.
This is my first time working with Rails & i18n and I didn't know about those rules. I'll go check the documentation you linked and I'll remember them for next time!
brianjaustin
added
Reviewed: Action Needed
Coder Has Actioned Review
and removed
Awaiting Review
Reviewed: Action Needed
labels
3 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7482
Purpose
The "About Us" page has been updated to include information about AO3, in addition to the information about OTW.
A link to the "About Us" page has been added to the sitemap.
Credit
Céline Bertaud (she/her)