AO3-7470 Always use first-party JQuery & JQuery UI#5850
Open
slavalamp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
AO3-7470: Move JQuery/JQuery UI to first party hosting
Purpose
Makes it so the site always serves its own JQuery JavaScript files (which were previously a fallback) instead of getting them from Google.
Notes
While the JS in our
jquery.js,jquery.min.jsandjquery-ui.jsfiles is exactly identical to Google's,jquery-ui.min.jslooks different for some reason. Things seem to work the same for me, and the automated tests should show if anything breaks there, I'm guessing that a different minifier just happened to get used at some point, but I'm also open to replacing the file if anyone feels it'd be safer to make it exactly identical to Google's.Also I have no idea why the error pages are loading any javascript at all...
Credit
slavalamp