fix: the substr function will return an empty string instead of false#41508
Merged
DeepDiver1975 merged 1 commit intomasterfrom Mar 20, 2026
Merged
fix: the substr function will return an empty string instead of false#41508DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the php8 update, the substr function returns an empty string instead of false.
In this particular cases, the
$mountPathcheck forfalsefails, causing the code to go through an unintended path. Information returned by the affected function (getUsersSharingFile) is wrong, and it can affect to other apps, such as the activity app (see linked ticket)Related Issue
Related to owncloud/activity#1230
Motivation and Context
Wrong information is stored and shown to the user. This PR fixes it.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: