fix(files/storage): add SSRF host validation to DAV storage constructor#41576
Open
DeepDiver1975 wants to merge 3 commits into
Open
fix(files/storage): add SSRF host validation to DAV storage constructor#41576DeepDiver1975 wants to merge 3 commits into
DeepDiver1975 wants to merge 3 commits into
Conversation
The DAV storage class accepted arbitrary host values (including loopback, link-local 169.254.x.x, RFC-1918 private ranges, and IPv6 equivalents) without validation. When user external storage mounting is enabled, any authenticated user could force the server to make HTTP requests to cloud metadata endpoints, localhost services, or internal network hosts. Adds validateHost() called immediately after scheme-stripping so all downstream HTTP sinks (Guzzle GET/PUT and Sabre DAV Client) are covered. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
… pass SSRF validation Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostwithout any IP range or hostname validationvalidateHost()method blocks loopback, link-local, private IPv4/IPv6 ranges before the value is storedSecurity Impact
High — SSRF allowing internal network reconnaissance and cloud metadata exfiltration when user mounting is enabled
Test plan
testSsrfBlockedHostThrows()— 23 blocked hosts (loopback, link-local, private ranges, IPv6 equivalents) each throw\InvalidArgumentExceptiontestSsrfAllowedHostDoesNotThrow()— 7 legitimate public hostnames pass through unchangedmake test TEST_PHP_SUITE=lib/private/Files/Storage🤖 Generated with Claude Code