fix(files_external): add SSRF host validation to external storage backend#41581
Open
DeepDiver1975 wants to merge 2 commits into
Open
fix(files_external): add SSRF host validation to external storage backend#41581DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
…kend UserStoragesController::create()/update() (@NoAdminRequired) accepted arbitrary host values for DAV, SMB, and other network backends without validating against private IP ranges, loopback, or link-local addresses. With user mounting enabled, authenticated users could force the server to make HTTP requests to cloud metadata endpoints (169.254.169.254), localhost services, or internal network hosts. Add validateHostOption() to StoragesController::validate(), which blocks RFC-1918 private ranges, loopback (127.x.x.x / ::1), IPv4 link-local (169.254.x.x), IPv6 link-local (fe80::/10), and ULA (fc00::/7). Admin escape-hatch: files_external_allow_private_address=true in config. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserStoragesController(@NoAdminRequired) accepted arbitraryhostvalues and immediately tested the connection, forcing outbound HTTP to any attacker-specified targetvalidateHostOption()inStoragesController::validate()blocking private ranges, loopback, link-local, and IPv6 equivalents; admin can opt out viafiles_external_allow_private_address=trueSecurity Impact
High — SSRF allowing cloud metadata exfiltration and internal network scanning for any authenticated user when user mounting is enabled
Note
This PR touches
StoragesController.php— merge beforesecurity/fix-files-external-info-disclosureto avoid conflicts.Test plan
make test TEST_PHP_SUITE=apps/files_external🤖 Generated with Claude Code