fix(login): add per-IP brute-force throttling to tryLogin()#41584
Open
DeepDiver1975 wants to merge 4 commits into
Open
fix(login): add per-IP brute-force throttling to tryLogin()#41584DeepDiver1975 wants to merge 4 commits into
DeepDiver1975 wants to merge 4 commits into
Conversation
The login endpoint had no rate limiting, account lockout, or progressive delay. A CSRF token obtained with a single GET could be reused for unlimited POST attempts. The emitFailedLogin() event had zero subscribers implementing any throttling. Add per-IP exponential backoff stored in oc_appconfig: after BRUTE_FORCE_MAX_ATTEMPTS (10) failures within a 600s window, each subsequent attempt costs 2^excess seconds of delay (capped at 25s). Successful login resets the counter. Feature is disabled when login_brute_force_protection=false in config.php. Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
…ypes Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
…ll them directly Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryLogin()had no rate limiting; CSRF token was reusable for unlimited attempts; zero throttle subscribers on theuser.loginfailedevent2^excessseconds sleep per attempt, capped at 25soc_appconfig; reset on success; disableable vialogin_brute_force_protection=falsein config.phpSecurity Impact
Medium — unlimited credential stuffing / password spraying against the HTML login form
Note
This PR touches the same files as
security/fix-login-user-enumeration— merge this one first.Test plan
make test TEST_PHP_SUITE=core/Controller🤖 Generated with Claude Code