Skip to content

Conversation

@anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Jan 16, 2026

Description

convert spaces.feature test to playwright test

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@anon-pradip anon-pradip self-assigned this Jan 16, 2026
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-spaces.feature branch from 425b360 to af00be4 Compare January 19, 2026 04:03
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-spaces.feature branch 6 times, most recently from 2a23283 to ddfbaff Compare January 20, 2026 08:13
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-spaces.feature branch 2 times, most recently from 17fc589 to 4af8285 Compare January 20, 2026 09:55
@anon-pradip anon-pradip force-pushed the test/e2e-playwright-admin-settings-spaces.feature branch from 4af8285 to 358c812 Compare January 20, 2026 10:48
@sonarqubecloud
Copy link

@anon-pradip anon-pradip marked this pull request as ready for review January 21, 2026 04:24
Comment on lines +184 to +185
names: string[]
ids: string[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
names: string[]
ids: string[]
projectSpaces: Array<{ name: string; id: string }>

Comment on lines +63 to +64
names: ['team'],
ids: ['team.1']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
names: ['team'],
ids: ['team.1']
projectSpaces: Array<{ name: string; id: string }>

spacesEnvironment,
stepUser: 'Admin',
id: 'team.b'
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
})
})
// And "Alice" logs out

Was this step intentionally skipped, or was it missed by mistake?

await ui.logInUser({ usersEnvironment, actorsEnvironment, stepUser: 'Alice' })
await ui.openApplication({ actorsEnvironment, stepUser: 'Alice', name: 'admin-settings' })
await ui.navigateToProjectSpaceManagementPage({ actorsEnvironment, stepUser: 'Alice' })
await ui.updateSpaceUsingContextMenu({
Copy link
Member

@nabim777 nabim777 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await ui.updateSpaceUsingContextMenu({
await ui.updateSpaceAttributeUsingContextMenu({

Maybe this

Comment on lines +330 to +331
key: string
attribute: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: string
attribute: string
key: changes|updates
attribute: name|subtitle|quota

Comment on lines +115 to +128
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.b',
attribute: 'subtitle',
value: 'Developer team-subtitle'
})
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.b',
attribute: 'quota',
value: '50'
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.b',
attribute: 'subtitle',
value: 'Developer team-subtitle'
})
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.b',
attribute: 'quota',
value: '50'
})
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.a',
attribute: 'subtitle',
value: 'Developer team-subtitle'
})
await ui.updateSpaceUsingContextMenu({
actorsEnvironment,
stepUser: 'Alice',
key: 'team.a',
attribute: 'quota',
value: '50'
})

Plz check if it's right or not.

Comment on lines +139 to +144
expect(
await ui.shouldSeeSpaces({
actorsEnvironment,
stepUser: 'Alice',
expectedSpaceIds: ['team.a', 'team.b']
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(
await ui.shouldSeeSpaces({
actorsEnvironment,
stepUser: 'Alice',
expectedSpaceIds: ['team.a', 'team.b']
})
expect(
await ui.userShouldSeeSpaces({
actorsEnvironment,
stepUser: 'Alice',
expectedSpaceIds: ['team.a']
})

Plz check this one also if it is right or not.

}
}

export async function shouldSeeSpaces({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export async function shouldSeeSpaces({
export async function userShouldSeeSpaces({

expectedSpaceIds: ['team.b']
})
).toBeFalsy()
await ui.logOutUser({ actorsEnvironment, stepUser: 'Brian' })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await ui.logOutUser({ actorsEnvironment, stepUser: 'Brian' })
await ui.logOutUser({ actorsEnvironment, stepUser: 'Brian' })

I think you have missed some steps

https://github.com/owncloud/web/blob/master/tests/e2e/cucumber/features/admin-settings/spaces.feature#L50

    When "Brian" logs in
    And "Brian" opens the "admin-settings" app
    And "Brian" navigates to the project spaces management page
    When "Brian" disables the space "team.b" using the context-menu
    And "Brian" deletes the space "team.b" using the context-menu
    Then "Brian" should not see the following spaces
      | id     |
      | team.b |

```

stepUser: 'Admin',
spaceName: 'team A',
members: [
{ user: 'Brian', shareType: 'user', role: 'Can edit' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ user: 'Brian', shareType: 'user', role: 'Can edit' },
{ user: 'Brian', shareType: 'user', role: 'Can edit with versions and trashbin' },

stepUser: 'Alice',
expectedMembers: [
{ user: 'Admin', role: 'Can manage' },
{ user: 'Brian', role: 'Can edit' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ user: 'Brian', role: 'Can edit' },
{ user: 'Brian', role: 'Can edit with versions and trashbin' },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants