Fix: iOS/iPadOS Safari compatibility: replace vh with svh and vw with svw #13527 #13528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
|
Author
|
@ownclouders Could someone please review this? Reviewer needed for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve iOS/iPadOS Safari compatibility, vh units should be replaced with svh and vw with svw, as Mobile Safari handles vh inconsistently due to dynamic browser UI resizing (address bar, toolbars), leading to layout jumps and incorrect viewport calculations. These new units are specifically to solve this problem and are supported for many years in all major borwsers.
Related Issue
Motivation and Context
It solves incompatibility with vw and vh css units in IOS/IpadOS Safari.
How Has This Been Tested?
No functional changes. Appearance was tested on Chrome Windows, Firefox Windows, Chrome Android (Galaxy S23), Firefox Android (Galaxy S23) and iPad Pro 12.9" 2020.
All devices with the latest software installed.
As expected, nothing has changed, except, the iPadOS version now behaves correctly.
Types of changes
vhandvwtosvhandsvw)