fix(web-runtime): [OCISDEV-909] add explicit sizes to logo assets#13842
Open
LukasHirt wants to merge 1 commit into
Open
fix(web-runtime): [OCISDEV-909] add explicit sizes to logo assets#13842LukasHirt wants to merge 1 commit into
LukasHirt wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mzner
approved these changes
Jun 4, 2026
The topbar logo was not visible in Firefox because the SVG files lacked explicit `width` and `height` attributes. Firefox requires these attributes to establish intrinsic dimensions when loading SVGs via `<img>`; without them it renders the image as 0×0. Chrome infers the dimensions from `viewBox` alone. Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt
force-pushed
the
chore/backport-logo-fix
branch
from
426fc0e to
4070440
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #13834