Skip to content

fix(web-app-password-protected-folders): [OCISDEV-917] fix theme switching and cancel button visibility#13843

Open
mzner wants to merge 1 commit into
masterfrom
fix/OCISDEV-917/password-protected-close-button-is-hard-to-see
Open

fix(web-app-password-protected-folders): [OCISDEV-917] fix theme switching and cancel button visibility#13843
mzner wants to merge 1 commit into
masterfrom
fix/OCISDEV-917/password-protected-close-button-is-hard-to-see

Conversation

@mzner
Copy link
Copy Markdown
Contributor

@mzner mzner commented Jun 5, 2026

Description

Fix theme switching issues where colors could get stuck or become unreadable until a page refresh. Additionally fix the cancel button in the password protected folder modal being invisible against the dark action bar background.

Changes:

  • Clear previous theme's custom properties before applying the new theme so stale values don't persist
  • Treat empty token strings as unset by removing the CSS property instead of setting it to blank
  • Style the cancel button in FolderViewModal to use brand contrast colors for visibility

Related Issue

Motivation and Context

When switching between themes, tokens from the previous theme were not cleared before applying the new theme, causing stale values to persist. Empty string values in theme tokens were overriding stylesheet defaults with nothing, making elements invisible. The cancel button in the password protected folder modal was invisible because its color matched the dark action bar background.

How Has This Been Tested?

  • test environment: local dev server with oCIS backend
  • test case 1: Switch between light and dark themes — verify no stale color values persist
  • test case 2: Open password protected folder modal — verify cancel button is visible and has proper hover/focus states

@mzner mzner requested a review from LukasHirt June 5, 2026 06:25
@kw-security
Copy link
Copy Markdown

kw-security commented Jun 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

…ching and cancel button visibility

Clear previous theme's custom properties before applying the new theme
so old values don't persist. Treat empty token strings as unset by
removing the property instead of setting it to blank. Also fix the
cancel button in the password protected folder modal being invisible
against the dark action bar background.
@mzner mzner force-pushed the fix/OCISDEV-917/password-protected-close-button-is-hard-to-see branch from 389a982 to febcf72 Compare June 5, 2026 06:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
41.0% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OCISDEV-941] Password Protected Folder Close folder button is hard to see

3 participants