fix(web-app-password-protected-folders): [OCISDEV-917] fix theme switching and cancel button visibility#13843
Open
mzner wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…ching and cancel button visibility Clear previous theme's custom properties before applying the new theme so old values don't persist. Treat empty token strings as unset by removing the property instead of setting it to blank. Also fix the cancel button in the password protected folder modal being invisible against the dark action bar background.
389a982 to
febcf72
Compare
|
LukasHirt
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Fix theme switching issues where colors could get stuck or become unreadable until a page refresh. Additionally fix the cancel button in the password protected folder modal being invisible against the dark action bar background.
Changes:
Related Issue
Close folderbutton is hard to see #13817Motivation and Context
When switching between themes, tokens from the previous theme were not cleared before applying the new theme, causing stale values to persist. Empty string values in theme tokens were overriding stylesheet defaults with nothing, making elements invisible. The cancel button in the password protected folder modal was invisible because its color matched the dark action bar background.
How Has This Been Tested?