fix(web-pkg): [OCISDEV-777] validate postMessage origin in embed mode…#13844
Open
awabcodes wants to merge 1 commit into
Open
fix(web-pkg): [OCISDEV-777] validate postMessage origin in embed mode…#13844awabcodes wants to merge 1 commit into
awabcodes wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
63811a6 to
6a55d79
Compare
mzner
reviewed
Jun 5, 2026
mzner
approved these changes
Jun 5, 2026
6a55d79 to
67d873c
Compare
|
LukasHirt
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




… modals
Description
The embed mode modals (
SaveAsModal,ExportAsPdfModal,FilePickerModal) registered globalwindowmessagelisteners and acted on incomingowncloud-embed:*messages without validatingevent.origin. Any page holding a reference to an authenticated ownCloud window (e.g. viawindow.open) could forge anowncloud-embed:select,owncloud-embed:file-pickorowncloud-embed:cancelmessage and trigger an authenticated file write in the victim's space (CSRF).Related Issue
Motivation and Context
How Has This Been Tested?
window.open+postMessage(payload, '*'); no file is created and the modal stays open (before the fix a file was written)Screenshots (if appropriate):
Open tasks: