Vertically centre radio and checkbox with label#3049
Merged
david-crespo merged 6 commits intomainfrom Mar 6, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Looks good to me — what do we do when a label wraps? Just avoid that? |
Contributor
Author
|
Yeah, alternatively we do |
This reverts commit d02e303.
david-crespo
reviewed
Mar 6, 2026
| // data-status used only for e2e testing | ||
| <div | ||
| className={cn('upload-step items-top flex gap-2 px-4 py-3', className)} | ||
| className={cn('upload-step flex gap-2 px-4 py-3', className)} |
Collaborator
There was a problem hiding this comment.
This and the side modal items-top weren't doing anything because items-top is not a thing. In both cases, I confirmed that changing it to items-start would have no effect and deleted the class instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3035