[7/n] make try_compare_flattened obey dry_run#18
Merged
sunshowers merged 3 commits intoMay 12, 2026
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
ahl
approved these changes
May 2, 2026
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
fair enough; if I recall correctly, the idea of dry_run was so we could have do un-ordered oneOf checks; looks like I either undid that or never finished that thought.
sunshowers
changed the title
sunshowers
changed the base branch from
sunshowers/spr/main.6n-make-try_compare_flattened-obey-dry_run
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/6n-make-try_compare_flattened-obey-dry_run
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(
dry_runis always set to false -- should we drop support for it entirely?)