-
Notifications
You must be signed in to change notification settings - Fork 3
[1/n] add git ref storage for older API versions #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sunshowers
wants to merge
10
commits into
main
Choose a base branch
from
sunshowers/spr/add-git-ref-storage-for-older-api-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[1/n] add git ref storage for older API versions #38
sunshowers
wants to merge
10
commits into
main
from
sunshowers/spr/add-git-ref-storage-for-older-api-versions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
Wow, that is awesome. Didn’t know you can do that. So the gitref effectively takes the old file out of the current list of files, allowing git to treat the change as a move? Edit: discussed in chat. Answer is yes. |
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Closed
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, older (non-latest) blessed API versions are stored as
.gitreffiles containing acommit:pathreference instead of the fullJSON content. This allows Git to detect new API versions as renames. (The format is designed to be fed into
git show).The git ref uses the first commit that introduced the file (not the current merge-base) to ensure references remain stable as history evolves.
Git ref storage is disabled by default. Enable with
ManagedApis::with_git_ref_storage(), or per-API withManagedApi::use_git_ref_storage().Demo in Omicron:
For more information, see RFD 634.
TODO:
allow per-version customization of gitref storage (useful when particular fixed versions are special in some way)will do this when we need it