Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 12, 2025

Closes #904

Only partially done; more changes needed described on the issue above. Then I ran into httpmock/httpmock#183 so my own testing is not complete.

@jayvdb jayvdb marked this pull request as ready for review October 12, 2025 23:42
@jayvdb jayvdb marked this pull request as draft October 12, 2025 23:59
@ahl ahl closed this Oct 20, 2025
@ahl ahl reopened this Oct 20, 2025
@danieleades
Copy link

would be great if this could get merged after httpmock/httpmock#206 is merged, since this addresses some bugs in progenitor's mock codegen

@ahl
Copy link
Collaborator

ahl commented Jan 7, 2026

would be great if this could get merged after httpmock/httpmock#206 is merged, since this addresses some bugs in progenitor's mock codegen

Did #1264 obviate the need for this or is it still relevant?

@danieleades
Copy link

would be great if this could get merged after httpmock/httpmock#206 is merged, since this addresses some bugs in progenitor's mock codegen

Did #1264 obviate the need for this or is it still relevant?

Stil need that upstream change into httpmock, and then the updated httpmock used in progenitor. The reason being that progenitor can generate mocks that attempt to pass &str to Then::json_body_obj, which fails to compile because of needlessly restrictive trait bounds on that method

@ahl
Copy link
Collaborator

ahl commented Jan 7, 2026

I meant: do we still need this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httpmock 0.8.0-alpha.1 breaks generated mocks

3 participants