Fix unix epoch showing for job started#367
Closed
oblakeerickson wants to merge 1 commit intooxidecomputer:mainfrom
Closed
Fix unix epoch showing for job started#367oblakeerickson wants to merge 1 commit intooxidecomputer:mainfrom
oblakeerickson wants to merge 1 commit intooxidecomputer:mainfrom
Conversation
Adding `.nullable()` allows null values to pass through as null rather than being coerced to a Date. Fixes oxidecomputer#353
Contributor
|
Appreciate it! I will give this a test and get it merged. |
Contributor
|
Hey, for transparency I likely won't get to testing this until January as there are a lot of other competing priorities currently. I will get back to it though, and my apologies for the delay. |
Contributor
Author
|
@augustuswm Thank you for letting me know, appreciate it. That's not a problem at all. No rush on my end. If I get the spare time over xmas break to work on some other PRs please know that anything I submit can be looked at whenever you get a chance and in 2026. |
Contributor
|
Superseding this with #370 . This particular issue is a symptom of the larger problem that we were still using and old version of the ts client generator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
.nullable()allows null values to pass through as null rather than being coerced to a Date.Fixes #353