Refactor boolean type definition for C++/-std=gnu23 compatibility#30
Open
Arawn-Davies wants to merge 1 commit intoozkl:masterfrom
Open
Refactor boolean type definition for C++/-std=gnu23 compatibility#30Arawn-Davies wants to merge 1 commit intoozkl:masterfrom
Arawn-Davies wants to merge 1 commit intoozkl:masterfrom
Conversation
Changed the definition of 'boolean' type for C++ & -std=gnu23 compatibility, and included base <stdbool.h> header. This is to help bring it more inline with other source ports (Chocolate Doom mainly) and keep compatibility with new toolchains I think. I didn't come up with this fix (https://blog.svgames.pl/article/the-little-bool-of-doom) but it's helped me work on a port of doomgeneric to PlayStation 2 How easy would it be to get audio working? I think only SDL 1.2 works well on that platform so I'll be using GSKit instead
Slavchu
suggested changes
Mar 22, 2026
Slavchu
left a comment
Slavchu
left a comment
There was a problem hiding this comment.
I don't know if this repository will update. However, it would be nice if you would resolve comments in case the author wakes up
| #else | ||
|
|
||
| typedef enum | ||
| { |
There was a problem hiding this comment.
seems like it is unnecessary to comment, Please, use
#ifndef __bool_true_false_are_defined as it may break compilation on old standards
| #include <inttypes.h> | ||
|
|
||
| #ifdef __cplusplus | ||
| #ifdef __cplusplus || defined(__bool_true_false_are_defined) |
There was a problem hiding this comment.
#ifdef -> #if defined(__cplusplus) || defined(__bool_true_false_are_defined)
| // Use builtin bool type with C++. | ||
|
|
||
| typedef bool boolean; | ||
| typedef int boolean; |
There was a problem hiding this comment.
why int? use unsigned char or something like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the definition of 'boolean' type for C++ & -std=gnu23 compatibility, and included base <stdbool.h> header.
This is to help bring it more inline with other source ports (Chocolate Doom mainly) and keep compatibility with new toolchains I think. I didn't come up with this fix (https://blog.svgames.pl/article/the-little-bool-of-doom) but it's helped me work on a port of doomgeneric to PlayStation 2
How easy would it be to get audio working? I think only SDL 1.2 works well on that platform so I'll be using GSKit instead