Oas3 support request body#143
Conversation
|
This pull request introduces 1 alert when merging 59e32e7 into 8c6e05b - view on LGTM.com new alerts:
|
ioggstream
left a comment
ioggstream
left a comment
There was a problem hiding this comment.
@d-al-ibm check the above suggestions.
src/gen-api-models.ts
Outdated
|
|
||
| // Get a schema from a request or response body | ||
| function getSchemaFromBody( | ||
| item: any, // OpenAPIV3.RequestBodyObject | |
There was a problem hiding this comment.
@d-al-ibm dopo che la logica funziona, una volta individuato il tipo, puoi metterlo: sarà solo OAS3.
ioggstream
force-pushed
the
oas3-support-request-body
branch
from
99883a7 to
d9205d7
Compare
|
This pull request introduces 1 alert when merging d9205d7 into cf55986 - view on LGTM.com new alerts:
|
|
hi @ioggstream, may you remind me why is this a draft and the status of open PR that can be safely merged into this repo: probably we should bump version to a major release. |
|
Ideally there are other patches to merge first, and this one should probably be rebased. Practically, we should merge Aymen's branch first, and then this one. It's draft because I worked on this alone, and a review is needed. If you're not experiencing issues on io-onboarding probably this code is worth reviewing and eventually merging. This will enable us to implement the PATCH support. |
2 participants
This PR
begin support request body on OAS3