Skip to content

Comments

Translate Chinese comments and messages to English in mise Java integration script#26

Merged
paigeman merged 2 commits into23-support-java_home-integration-for-misefrom
copilot/sub-pr-24-again
Jan 22, 2026
Merged

Translate Chinese comments and messages to English in mise Java integration script#26
paigeman merged 2 commits into23-support-java_home-integration-for-misefrom
copilot/sub-pr-24-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 22, 2026

Addresses feedback from PR #24 to internationalize the mise_java_home_integration.sh script by replacing Chinese text with English throughout.

Changes

  • Comments: Translated inline comments explaining logic and section headers
  • Error messages: Converted all error output (e.g., "错误: 未找到 mise 命令" → "Error: mise command not found")
  • User prompts: Changed interactive confirmations and informational messages to English
  • Usage instructions: Translated help text in the argument parsing section

Example:

# Before
echo "❌ 错误: 当前目录没有激活任何 Mise Java 版本。"
echo "💡 请先执行: mise use java@21 (或你想要的版本)"

# After
echo "❌ Error: No Mise Java version is active in the current directory."
echo "💡 Please run: mise use java@21 (or your desired version)"

Script functionality unchanged.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: paigeman <53284808+paigeman@users.noreply.github.com>
Copilot AI changed the title [WIP] Update mise Java integration with macOS java_home script Translate Chinese comments and messages to English in mise Java integration script Jan 22, 2026
@paigeman paigeman marked this pull request as ready for review January 22, 2026 14:29
Copilot AI requested a review from paigeman January 22, 2026 14:29
Copy link
Owner

@paigeman paigeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paigeman paigeman merged commit 3a0ace0 into 23-support-java_home-integration-for-mise Jan 22, 2026
@paigeman paigeman deleted the copilot/sub-pr-24-again branch January 22, 2026 14:32
paigeman added a commit that referenced this pull request Jan 22, 2026
…ration script (#26)

* Initial plan

* Translate Chinese comments and messages to English

Co-authored-by: paigeman <53284808+paigeman@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: paigeman <53284808+paigeman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants