Clarify realpath vs readlink fallback logic in Java integration script#28
Closed
Copilot wants to merge 1 commit into23-support-java_home-integration-for-misefrom
Closed
Clarify realpath vs readlink fallback logic in Java integration script#28Copilot wants to merge 1 commit into23-support-java_home-integration-for-misefrom
Copilot wants to merge 1 commit into23-support-java_home-integration-for-misefrom
Conversation
Copilot
AI
changed the title
[WIP] Update Java integration script for macOS java_home
Clarify realpath vs readlink fallback logic in Java integration script
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review question about the difference between the current
realpath/readlinkfallback implementation and the suggested alternative approach.Context
The script verifies symbolic links by comparing resolved paths. Lines 78-86 implement a fallback pattern:
Response
Both the current implementation and the suggested
command -v realpathcheck achieve the same result:realpath, suppresses errors via2>/dev/null, falls back on empty outputrealpathexistence first, then attempts itThe current approach is sufficient because error suppression handles both "command not found" and "command failed" cases. The explicit availability check adds verbosity without functional benefit in this context.
No code changes required—current implementation is correct.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.